[Webkit-unassigned] [Bug 157669] ResourceTiming entries for cached resources and XHR

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=157669

--- Comment #7 from Yoav Weiss <yoav at yoav.ws> ---
(In reply to comment #5)
> Comment on attachment 278832 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=278832&action=review
> 
> > Source/WebCore/loader/ResourceTimingInformation.cpp:14
> > + *     * Neither the name of Google Inc. nor the names of its
> 
> I'm not sure this is the correct copyright.

Indeed! Corrected

> 
> > Source/WebCore/loader/ResourceTimingInformation.cpp:57
> > +                initiatorDocument = document->parentDocument();
> 
> What if there are deeply nested iframes?  Should this be topDocument()?

I believe each iframe is reported as a resource in its parent document, so the above should by correct. FWIW, I didn't change the existing logic but just moved it from CachedResourceLoader to here.

> 
> > Source/WebCore/loader/ResourceTimingInformation.h:32
> > +#ifndef ResourceTimingInformation_h
> > +#define ResourceTimingInformation_h
> 
> #pragma once is the latest thing in WebKit.

Neat! Changed

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160513/8c05622e/attachment.html>