<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - ResourceTiming entries for cached resources and XHR"
href="https://bugs.webkit.org/show_bug.cgi?id=157669#c7">Comment # 7</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - ResourceTiming entries for cached resources and XHR"
href="https://bugs.webkit.org/show_bug.cgi?id=157669">bug 157669</a>
from <span class="vcard"><a class="email" href="mailto:yoav@yoav.ws" title="Yoav Weiss <yoav@yoav.ws>"> <span class="fn">Yoav Weiss</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=157669#c5">comment #5</a>)
<span class="quote">> Comment on <span class="bz_obsolete"><a href="attachment.cgi?id=278832&action=diff" name="attach_278832" title="Patch">attachment 278832</a> <a href="attachment.cgi?id=278832&action=edit" title="Patch">[details]</a></span>
> Patch
>
> View in context:
> <a href="https://bugs.webkit.org/attachment.cgi?id=278832&action=review">https://bugs.webkit.org/attachment.cgi?id=278832&action=review</a>
>
> > Source/WebCore/loader/ResourceTimingInformation.cpp:14
> > + * * Neither the name of Google Inc. nor the names of its
>
> I'm not sure this is the correct copyright.</span >
Indeed! Corrected
<span class="quote">>
> > Source/WebCore/loader/ResourceTimingInformation.cpp:57
> > + initiatorDocument = document->parentDocument();
>
> What if there are deeply nested iframes? Should this be topDocument()?</span >
I believe each iframe is reported as a resource in its parent document, so the above should by correct. FWIW, I didn't change the existing logic but just moved it from CachedResourceLoader to here.
<span class="quote">>
> > Source/WebCore/loader/ResourceTimingInformation.h:32
> > +#ifndef ResourceTimingInformation_h
> > +#define ResourceTimingInformation_h
>
> #pragma once is the latest thing in WebKit.</span >
Neat! Changed</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>