[Webkit-unassigned] [Bug 156147] [JSC] implement async functions proposal

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu May 12 09:34:55 PDT 2016


--- Comment #82 from Caitlin Potter (:caitp) <caitp at igalia.com> ---
Comment on attachment 278692
  --> https://bugs.webkit.org/attachment.cgi?id=278692

View in context: https://bugs.webkit.org/attachment.cgi?id=278692&action=review

Thanks --- I've removed the bits that snuck in by mistake.

>> Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:509
>> +        if (!haveParameterNamedArguments && !m_codeBlock->isArrowFunction() && !m_codeBlock->isAsyncArrowFunction()) {
> isAsyncArrowFunction is included in isArrowFunction().

Yeah, the last patchset was actually supposed to remove these, but it got undone by mistake. They're gone now

>> Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:4313
>> +    ASSERT(m_codeBlock->isArrowFunction() || parseMode() == SourceParseMode::AsyncArrowFunctionBodyMode || parseMode() == SourceParseMode::AsyncArrowFunctionMode || m_codeBlock->isArrowFunctionContext() || constructorKind() == ConstructorKind::Derived || m_codeType == EvalCode);
> Is this `SourceParseMode::AsyncArrowFunctionBodyMode` correct?

I'm not sure how else to make this work --- there's probably a better way, but for the purposes of this patch, I think we can do it for the body function too. Ditto for the other one of these

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160512/a45f4ad0/attachment-0001.html>

More information about the webkit-unassigned mailing list