<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [JSC] implement async functions proposal"
href="https://bugs.webkit.org/show_bug.cgi?id=156147#c82">Comment # 82</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [JSC] implement async functions proposal"
href="https://bugs.webkit.org/show_bug.cgi?id=156147">bug 156147</a>
from <span class="vcard"><a class="email" href="mailto:caitp@igalia.com" title="Caitlin Potter (:caitp) <caitp@igalia.com>"> <span class="fn">Caitlin Potter (:caitp)</span></a>
</span></b>
<pre>Comment on <span class="bz_obsolete"><a href="attachment.cgi?id=278692&action=diff" name="attach_278692" title="Patch">attachment 278692</a> <a href="attachment.cgi?id=278692&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=278692&action=review">https://bugs.webkit.org/attachment.cgi?id=278692&action=review</a>
Thanks --- I've removed the bits that snuck in by mistake.
<span class="quote">>> Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:509
>> + if (!haveParameterNamedArguments && !m_codeBlock->isArrowFunction() && !m_codeBlock->isAsyncArrowFunction()) {
>
> isAsyncArrowFunction is included in isArrowFunction().</span >
Yeah, the last patchset was actually supposed to remove these, but it got undone by mistake. They're gone now
<span class="quote">>> Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:4313
>> + ASSERT(m_codeBlock->isArrowFunction() || parseMode() == SourceParseMode::AsyncArrowFunctionBodyMode || parseMode() == SourceParseMode::AsyncArrowFunctionMode || m_codeBlock->isArrowFunctionContext() || constructorKind() == ConstructorKind::Derived || m_codeType == EvalCode);
>
> Is this `SourceParseMode::AsyncArrowFunctionBodyMode` correct?</span >
I'm not sure how else to make this work --- there's probably a better way, but for the purposes of this patch, I think we can do it for the body function too. Ditto for the other one of these</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>