[Webkit-unassigned] [Bug 157167] r200216 fails to build for darwin/gtk: use of undeclared identifier 'm_font'

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=157167

--- Comment #15 from Myles C. Maxfield <mmaxfield at apple.com> ---
(In reply to comment #14)
> (In reply to comment #9)
> > It seems to me like it should be something like this:
> 
> Better, and will almost certainly solve the problem, but not I am not sure
> this is quite right.
> 
> > #elif PLATFORM(COCOA)
> 
> This should probably be USE(APPKIT) || xxx
> 
> Myles, what are we using elsewhere in the font code? Are we using
> PLATFORM(COCOA)?

I've mostly seen #if blocks mentioning COCOA / MAC / IOS.


For the issue about being a first-party port, I can refer you to https://trac.webkit.org/wiki/SuccessfulPortHowTo. Usually we require the following before a port is considered first party:

- A buildbot running that reports results to https://build.webkit.org/dashboard/
- Two reviewers who are familiar with the port

I'm happy to review patches to keep these non-first-party ports up and running, but you should know that breakages like these will likely continue until the port is considered first party.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160506/2aa28b15/attachment.html>