<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - r200216 fails to build for darwin/gtk: use of undeclared identifier 'm_font'"
href="https://bugs.webkit.org/show_bug.cgi?id=157167#c15">Comment # 15</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - r200216 fails to build for darwin/gtk: use of undeclared identifier 'm_font'"
href="https://bugs.webkit.org/show_bug.cgi?id=157167">bug 157167</a>
from <span class="vcard"><a class="email" href="mailto:mmaxfield@apple.com" title="Myles C. Maxfield <mmaxfield@apple.com>"> <span class="fn">Myles C. Maxfield</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=157167#c14">comment #14</a>)
<span class="quote">> (In reply to <a href="show_bug.cgi?id=157167#c9">comment #9</a>)
> > It seems to me like it should be something like this:
>
> Better, and will almost certainly solve the problem, but not I am not sure
> this is quite right.
>
> > #elif PLATFORM(COCOA)
>
> This should probably be USE(APPKIT) || xxx
>
> Myles, what are we using elsewhere in the font code? Are we using
> PLATFORM(COCOA)?</span >
I've mostly seen #if blocks mentioning COCOA / MAC / IOS.
For the issue about being a first-party port, I can refer you to <a href="https://trac.webkit.org/wiki/SuccessfulPortHowTo">https://trac.webkit.org/wiki/SuccessfulPortHowTo</a>. Usually we require the following before a port is considered first party:
- A buildbot running that reports results to <a href="https://build.webkit.org/dashboard/">https://build.webkit.org/dashboard/</a>
- Two reviewers who are familiar with the port
I'm happy to review patches to keep these non-first-party ports up and running, but you should know that breakages like these will likely continue until the port is considered first party.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>