[Webkit-unassigned] [Bug 157167] r200216 fails to build for darwin/gtk: use of undeclared identifier 'm_font'

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=157167

--- Comment #8 from Carlos Garcia Campos <cgarcia at igalia.com> ---
The ifdef is in that line, see the whole context:

    unsigned hash() const
    {
#if PLATFORM(WIN) && !USE(CAIRO)
        return m_font ? m_font->hash() : 0;
#elif OS(DARWIN)
        uintptr_t flags = static_cast<uintptr_t>(m_isHashTableDeletedValue << 5 | m_textRenderingMode << 3 | m_orientation << 2 | m_syntheticBold << 1 | m_syntheticOblique);
#if USE(APPKIT)
        uintptr_t fontHash = (uintptr_t)m_font.get();
#else
        uintptr_t fontHash = reinterpret_cast<uintptr_t>(CFHash(m_font.get()));
#endif
        uintptr_t hashCodes[3] = { fontHash, m_widthVariant, flags };
        return StringHasher::hashMemory<sizeof(hashCodes)>(hashCodes);
#elif USE(CAIRO)
        return PtrHash<cairo_scaled_font_t*>::hash(m_scaledFont.get());
#endif
    }

http://trac.webkit.org/browser/trunk/Source/WebCore/platform/graphics/FontPlatformData.h#L168

If cairo is used when building WebKitGTK+ on darwin, we should be using the cairo implementation of the hash. But I don't know if we should just replace the OS(DARWIN) by PLATFORM(COCOA) or change the order of the ifdefs.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160506/b3b69193/attachment.html>