<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - r200216 fails to build for darwin/gtk: use of undeclared identifier 'm_font'"
href="https://bugs.webkit.org/show_bug.cgi?id=157167#c8">Comment # 8</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - r200216 fails to build for darwin/gtk: use of undeclared identifier 'm_font'"
href="https://bugs.webkit.org/show_bug.cgi?id=157167">bug 157167</a>
from <span class="vcard"><a class="email" href="mailto:cgarcia@igalia.com" title="Carlos Garcia Campos <cgarcia@igalia.com>"> <span class="fn">Carlos Garcia Campos</span></a>
</span></b>
<pre>The ifdef is in that line, see the whole context:
unsigned hash() const
{
#if PLATFORM(WIN) && !USE(CAIRO)
return m_font ? m_font->hash() : 0;
#elif OS(DARWIN)
uintptr_t flags = static_cast<uintptr_t>(m_isHashTableDeletedValue << 5 | m_textRenderingMode << 3 | m_orientation << 2 | m_syntheticBold << 1 | m_syntheticOblique);
#if USE(APPKIT)
uintptr_t fontHash = (uintptr_t)m_font.get();
#else
uintptr_t fontHash = reinterpret_cast<uintptr_t>(CFHash(m_font.get()));
#endif
uintptr_t hashCodes[3] = { fontHash, m_widthVariant, flags };
return StringHasher::hashMemory<sizeof(hashCodes)>(hashCodes);
#elif USE(CAIRO)
return PtrHash<cairo_scaled_font_t*>::hash(m_scaledFont.get());
#endif
}
<a href="http://trac.webkit.org/browser/trunk/Source/WebCore/platform/graphics/FontPlatformData.h#L168">http://trac.webkit.org/browser/trunk/Source/WebCore/platform/graphics/FontPlatformData.h#L168</a>
If cairo is used when building WebKitGTK+ on darwin, we should be using the cairo implementation of the hash. But I don't know if we should just replace the OS(DARWIN) by PLATFORM(COCOA) or change the order of the ifdefs.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>