[Webkit-unassigned] [Bug 116046] For keyboard users, activating a fragment URL should transfer focus and caret to the destination

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=116046

--- Comment #42 from Ryosuke Niwa <rniwa at webkit.org> ---
(In reply to comment #41)
> (In reply to comment #40)
> > > Source/WebCore/dom/Document.cpp:4085
> > > +    return node.previousSibling() ?: node.parentNode();
> > 
> > Use || instead.
> What do you mean by this? We need to return a Node object from this function.

Oh oops, you're right. Can't do that in C++. Please do:
node.previousSibling() ? node.previousSibling() : node.parentNode()
instead as that's what we do elsewhere in our codebase.

Alternatively,
if (node.previousSibling())
    return node.previousSibling();
return node.parentNode();

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160505/3d0a9f96/attachment.html>