<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_ASSIGNED "
title="ASSIGNED - For keyboard users, activating a fragment URL should transfer focus and caret to the destination"
href="https://bugs.webkit.org/show_bug.cgi?id=116046#c42">Comment # 42</a>
on <a class="bz_bug_link
bz_status_ASSIGNED "
title="ASSIGNED - For keyboard users, activating a fragment URL should transfer focus and caret to the destination"
href="https://bugs.webkit.org/show_bug.cgi?id=116046">bug 116046</a>
from <span class="vcard"><a class="email" href="mailto:rniwa@webkit.org" title="Ryosuke Niwa <rniwa@webkit.org>"> <span class="fn">Ryosuke Niwa</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=116046#c41">comment #41</a>)
<span class="quote">> (In reply to <a href="show_bug.cgi?id=116046#c40">comment #40</a>)
> > > Source/WebCore/dom/Document.cpp:4085
> > > + return node.previousSibling() ?: node.parentNode();
> >
> > Use || instead.
> What do you mean by this? We need to return a Node object from this function.</span >
Oh oops, you're right. Can't do that in C++. Please do:
node.previousSibling() ? node.previousSibling() : node.parentNode()
instead as that's what we do elsewhere in our codebase.
Alternatively,
if (node.previousSibling())
return node.previousSibling();
return node.parentNode();</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>