[Webkit-unassigned] [Bug 156184] [wincairo] web inspector failed to launch in MiniBrowser

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=156184

Joseph Pecoraro <joepeck at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #275581|commit-queue?               |commit-queue-
              Flags|                            |

--- Comment #8 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 275581
  --> https://bugs.webkit.org/attachment.cgi?id=275581
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=275581&action=review

>> Tools/MiniBrowser/win/MiniBrowser.cpp:199
>> +    m_prefsPrivate->setAllowUniversalAccessFromFileURLs(TRUE);
> 
> Errr, why is MiniBrowser be setting this preference? I think it should be the Web Inspector on Windows that should be setting it. Is this a WebKit1 window, or WebKit2?

If this is WebKit1 could this preference be set in:
Source/WebKit/win/WebCoreSupport/WebInspectorClient.cpp - WebInspectorClient::openLocalFrontend

If this is WebKit2, other ports set this in their inspector page configuration in:
Source/WebKit2/UIProcess/mac/WebInspectorProxyMac.mm - WebInspectorProxy::platformCreateInspectorPage
Source/WebKit2/UIProcess/mac/WebInspectorProxyEfl.cpp - WebInspectorProxy::platformCreateInspectorPage

Perhaps this should be added to other ports (gtk) as well. cq- while the question gets answered.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160504/36dcd17d/attachment.html>