<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:joepeck@webkit.org" title="Joseph Pecoraro <joepeck@webkit.org>"> <span class="fn">Joseph Pecoraro</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - [wincairo] web inspector failed to launch in MiniBrowser"
href="https://bugs.webkit.org/show_bug.cgi?id=156184">bug 156184</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #275581 Flags</td>
<td>commit-queue?
</td>
<td>commit-queue-
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [wincairo] web inspector failed to launch in MiniBrowser"
href="https://bugs.webkit.org/show_bug.cgi?id=156184#c8">Comment # 8</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [wincairo] web inspector failed to launch in MiniBrowser"
href="https://bugs.webkit.org/show_bug.cgi?id=156184">bug 156184</a>
from <span class="vcard"><a class="email" href="mailto:joepeck@webkit.org" title="Joseph Pecoraro <joepeck@webkit.org>"> <span class="fn">Joseph Pecoraro</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=275581&action=diff" name="attach_275581" title="Patch">attachment 275581</a> <a href="attachment.cgi?id=275581&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=275581&action=review">https://bugs.webkit.org/attachment.cgi?id=275581&action=review</a>
<span class="quote">>> Tools/MiniBrowser/win/MiniBrowser.cpp:199
>> + m_prefsPrivate->setAllowUniversalAccessFromFileURLs(TRUE);
>
> Errr, why is MiniBrowser be setting this preference? I think it should be the Web Inspector on Windows that should be setting it. Is this a WebKit1 window, or WebKit2?</span >
If this is WebKit1 could this preference be set in:
Source/WebKit/win/WebCoreSupport/WebInspectorClient.cpp - WebInspectorClient::openLocalFrontend
If this is WebKit2, other ports set this in their inspector page configuration in:
Source/WebKit2/UIProcess/mac/WebInspectorProxyMac.mm - WebInspectorProxy::platformCreateInspectorPage
Source/WebKit2/UIProcess/mac/WebInspectorProxyEfl.cpp - WebInspectorProxy::platformCreateInspectorPage
Perhaps this should be added to other ports (gtk) as well. cq- while the question gets answered.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>