[Webkit-unassigned] [Bug 157270] Add fail-fast option to run-javascriptcore-tests

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=157270

Geoffrey Garen <ggaren at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #277912|review?, commit-queue?      |review+, commit-queue-
              Flags|                            |

--- Comment #2 from Geoffrey Garen <ggaren at apple.com> ---
Comment on attachment 277912
  --> https://bugs.webkit.org/attachment.cgi?id=277912
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=277912&action=review

r=me

> Tools/Scripts/run-javascriptcore-tests:211
> +    if ($failFast) {
> +        exit exitStatus($testapiResult) if $testapiResult;

Since we have two conditions here, I think it's clearer to merge them into one if statement:

if ($testapiResult && $failFast) {
    exit...
}

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160502/a1d72c2c/attachment.html>