<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:ggaren@apple.com" title="Geoffrey Garen <ggaren@apple.com>"> <span class="fn">Geoffrey Garen</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - Add fail-fast option to run-javascriptcore-tests"
href="https://bugs.webkit.org/show_bug.cgi?id=157270">bug 157270</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #277912 Flags</td>
<td>review?, commit-queue?
</td>
<td>review+, commit-queue-
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Add fail-fast option to run-javascriptcore-tests"
href="https://bugs.webkit.org/show_bug.cgi?id=157270#c2">Comment # 2</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Add fail-fast option to run-javascriptcore-tests"
href="https://bugs.webkit.org/show_bug.cgi?id=157270">bug 157270</a>
from <span class="vcard"><a class="email" href="mailto:ggaren@apple.com" title="Geoffrey Garen <ggaren@apple.com>"> <span class="fn">Geoffrey Garen</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=277912&action=diff" name="attach_277912" title="Patch">attachment 277912</a> <a href="attachment.cgi?id=277912&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=277912&action=review">https://bugs.webkit.org/attachment.cgi?id=277912&action=review</a>
r=me
<span class="quote">> Tools/Scripts/run-javascriptcore-tests:211
> + if ($failFast) {
> + exit exitStatus($testapiResult) if $testapiResult;</span >
Since we have two conditions here, I think it's clearer to merge them into one if statement:
if ($testapiResult && $failFast) {
exit...
}</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>