[Webkit-unassigned] [Bug 157267] New: Cleanup: Move policy decision for when to apply app quirks and workarounds into separate file

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=157267

            Bug ID: 157267
           Summary: Cleanup: Move policy decision for when to apply app
                    quirks and workarounds into separate file
    Classification: Unclassified
           Product: WebKit
           Version: WebKit Local Build
          Hardware: Macintosh
                OS: All
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: WebKit Misc.
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: dbates at webkit.org
                CC: darin at apple.com

Following up on a suggestion by Darin Adler in bug 157252, comment 2, we should extract the policy logic for when to apply a quirk or workaround from file Source/WebKit/mac/WebView/WebView.mm into a separate header file and implementation file. For convenience, the following is what Darin wrote:

[[
We should ... [group] ... functions that make decisions about ... quirks and workarounds in a header analogous to the RuntimeApplicationChecks one. This header would never mention specific application but would just list all the different quirks. The implementation file would contain all the expressions used to decide when each quirk applies, and comments about why each implements the right policy.

The implementations of the quirks would continue to be distributed throughout the code, but the policy of which quirks apply when would be grouped together.
]]

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160502/f516b7ef/attachment.html>