<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>Bug ID</th>
<td><a class="bz_bug_link
bz_status_NEW "
title="NEW - Cleanup: Move policy decision for when to apply app quirks and workarounds into separate file"
href="https://bugs.webkit.org/show_bug.cgi?id=157267">157267</a>
</td>
</tr>
<tr>
<th>Summary</th>
<td>Cleanup: Move policy decision for when to apply app quirks and workarounds into separate file
</td>
</tr>
<tr>
<th>Classification</th>
<td>Unclassified
</td>
</tr>
<tr>
<th>Product</th>
<td>WebKit
</td>
</tr>
<tr>
<th>Version</th>
<td>WebKit Local Build
</td>
</tr>
<tr>
<th>Hardware</th>
<td>Macintosh
</td>
</tr>
<tr>
<th>OS</th>
<td>All
</td>
</tr>
<tr>
<th>Status</th>
<td>NEW
</td>
</tr>
<tr>
<th>Severity</th>
<td>Normal
</td>
</tr>
<tr>
<th>Priority</th>
<td>P2
</td>
</tr>
<tr>
<th>Component</th>
<td>WebKit Misc.
</td>
</tr>
<tr>
<th>Assignee</th>
<td>webkit-unassigned@lists.webkit.org
</td>
</tr>
<tr>
<th>Reporter</th>
<td>dbates@webkit.org
</td>
</tr>
<tr>
<th>CC</th>
<td>darin@apple.com
</td>
</tr></table>
<p>
<div>
<pre>Following up on a suggestion by Darin Adler in <a class="bz_bug_link
bz_status_NEW "
title="NEW - CSP: Add workaround for XtraMath"
href="show_bug.cgi?id=157252#c2">bug 157252, comment 2</a>, we should extract the policy logic for when to apply a quirk or workaround from file Source/WebKit/mac/WebView/WebView.mm into a separate header file and implementation file. For convenience, the following is what Darin wrote:
[[
We should ... [group] ... functions that make decisions about ... quirks and workarounds in a header analogous to the RuntimeApplicationChecks one. This header would never mention specific application but would just list all the different quirks. The implementation file would contain all the expressions used to decide when each quirk applies, and comments about why each implements the right policy.
The implementations of the quirks would continue to be distributed throughout the code, but the policy of which quirks apply when would be grouped together.
]]</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>