[Webkit-unassigned] [Bug 149813] [Win] Clean up annoying compiler warnings

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=149813

Alex Christensen <achristensen at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #277893|review?                     |review+
              Flags|                            |

--- Comment #2 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 277893
  --> https://bugs.webkit.org/attachment.cgi?id=277893
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=277893&action=review

> Source/JavaScriptCore/runtime/RegExpPrototype.cpp:178
> +    string[0] = 0;

This adds an unnecessary operation in the common case where no error happens.  Could we add this only if we are returning early?

> Source/JavaScriptCore/runtime/SamplingProfiler.cpp:678
> -        return -1;
> +        return UINT_MAX;

We typically use std::numeric_limits<unsigned>::max()

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160502/da8d20f3/attachment.html>