<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:achristensen@apple.com" title="Alex Christensen <achristensen@apple.com>"> <span class="fn">Alex Christensen</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - [Win] Clean up annoying compiler warnings"
href="https://bugs.webkit.org/show_bug.cgi?id=149813">bug 149813</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #277893 Flags</td>
<td>review?
</td>
<td>review+
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [Win] Clean up annoying compiler warnings"
href="https://bugs.webkit.org/show_bug.cgi?id=149813#c2">Comment # 2</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [Win] Clean up annoying compiler warnings"
href="https://bugs.webkit.org/show_bug.cgi?id=149813">bug 149813</a>
from <span class="vcard"><a class="email" href="mailto:achristensen@apple.com" title="Alex Christensen <achristensen@apple.com>"> <span class="fn">Alex Christensen</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=277893&action=diff" name="attach_277893" title="Patch">attachment 277893</a> <a href="attachment.cgi?id=277893&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=277893&action=review">https://bugs.webkit.org/attachment.cgi?id=277893&action=review</a>
<span class="quote">> Source/JavaScriptCore/runtime/RegExpPrototype.cpp:178
> + string[0] = 0;</span >
This adds an unnecessary operation in the common case where no error happens. Could we add this only if we are returning early?
<span class="quote">> Source/JavaScriptCore/runtime/SamplingProfiler.cpp:678
> - return -1;
> + return UINT_MAX;</span >
We typically use std::numeric_limits<unsigned>::max()</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>