[Webkit-unassigned] [Bug 157249] Deduplicated initializer lists of BitmapImage constructors.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun May 1 16:37:57 PDT 2016


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
 Attachment #277869|review?                     |review+
              Flags|                            |

--- Comment #2 from Darin Adler <darin at apple.com> ---
Comment on attachment 277869
  --> https://bugs.webkit.org/attachment.cgi?id=277869

View in context: https://bugs.webkit.org/attachment.cgi?id=277869&action=review

> Source/WebCore/platform/graphics/BitmapImage.cpp:48
> +BitmapImage::BitmapImage(ImageObserver* observer, bool fromNativeImage)

This approach of taking a boolean is a little bit inelegant, violates our coding style rule of not using literal "true" for a mysterious meaning that requires reading the code to find out what it means, and also adds a few branches to the constructors, but I think it’s OK.

> Source/WebCore/platform/graphics/BitmapImage.h:302
> +    int m_repetitionCount { cAnimationNone }; // How many total animation loops we should do.

Not sure why we removed the comment explaining the meaning of cAnimationNone. Might be better to move it somewhere rather than removing it entirely.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160501/6eb2583c/attachment-0001.html>

More information about the webkit-unassigned mailing list