<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:darin@apple.com" title="Darin Adler <darin@apple.com>"> <span class="fn">Darin Adler</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - Deduplicated initializer lists of BitmapImage constructors."
href="https://bugs.webkit.org/show_bug.cgi?id=157249">bug 157249</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #277869 Flags</td>
<td>review?
</td>
<td>review+
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Deduplicated initializer lists of BitmapImage constructors."
href="https://bugs.webkit.org/show_bug.cgi?id=157249#c2">Comment # 2</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Deduplicated initializer lists of BitmapImage constructors."
href="https://bugs.webkit.org/show_bug.cgi?id=157249">bug 157249</a>
from <span class="vcard"><a class="email" href="mailto:darin@apple.com" title="Darin Adler <darin@apple.com>"> <span class="fn">Darin Adler</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=277869&action=diff" name="attach_277869" title="Patch">attachment 277869</a> <a href="attachment.cgi?id=277869&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=277869&action=review">https://bugs.webkit.org/attachment.cgi?id=277869&action=review</a>
<span class="quote">> Source/WebCore/platform/graphics/BitmapImage.cpp:48
> +BitmapImage::BitmapImage(ImageObserver* observer, bool fromNativeImage)</span >
This approach of taking a boolean is a little bit inelegant, violates our coding style rule of not using literal "true" for a mysterious meaning that requires reading the code to find out what it means, and also adds a few branches to the constructors, but I think it’s OK.
<span class="quote">> Source/WebCore/platform/graphics/BitmapImage.h:302
> + int m_repetitionCount { cAnimationNone }; // How many total animation loops we should do.</span >
Not sure why we removed the comment explaining the meaning of cAnimationNone. Might be better to move it somewhere rather than removing it entirely.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>