[Webkit-unassigned] [Bug 156084] AX: AX hit-testing does not work on WebKit video playback buttons

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=156084

Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #275354|review?                     |review+
              Flags|                            |

--- Comment #4 from Darin Adler <darin at apple.com> ---
Comment on attachment 275354
  --> https://bugs.webkit.org/attachment.cgi?id=275354
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=275354&action=review

> Source/WebCore/accessibility/AccessibilityRenderObject.cpp:2260
> +    if (!shadowHost)
> +        return false;
> +    
> +    if (shadowHost->hasTagName(videoTag))
> +        return false;
> +    
> +    return true;

Cleaner way to write this:

    return shadowHost && shadowHost->hasTagName(videoTag);

But also, this needs a comment explaining why this is the correct implementation for this function. What is special about video tags?

> Source/WebCore/accessibility/AccessibilityRenderObject.cpp:2277
> +    Node* node = hitTestResult.innerNode();

Should put this into a local variable before the early return just above.

    Node* node = hitTestResult.innerNode();
    if (!node)
        return nullptr;

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160401/f92a547d/attachment-0001.html>