<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:darin@apple.com" title="Darin Adler <darin@apple.com>"> <span class="fn">Darin Adler</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - AX: AX hit-testing does not work on WebKit video playback buttons"
href="https://bugs.webkit.org/show_bug.cgi?id=156084">bug 156084</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #275354 Flags</td>
<td>review?
</td>
<td>review+
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - AX: AX hit-testing does not work on WebKit video playback buttons"
href="https://bugs.webkit.org/show_bug.cgi?id=156084#c4">Comment # 4</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - AX: AX hit-testing does not work on WebKit video playback buttons"
href="https://bugs.webkit.org/show_bug.cgi?id=156084">bug 156084</a>
from <span class="vcard"><a class="email" href="mailto:darin@apple.com" title="Darin Adler <darin@apple.com>"> <span class="fn">Darin Adler</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=275354&action=diff" name="attach_275354" title="patch">attachment 275354</a> <a href="attachment.cgi?id=275354&action=edit" title="patch">[details]</a></span>
patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=275354&action=review">https://bugs.webkit.org/attachment.cgi?id=275354&action=review</a>
<span class="quote">> Source/WebCore/accessibility/AccessibilityRenderObject.cpp:2260
> + if (!shadowHost)
> + return false;
> +
> + if (shadowHost->hasTagName(videoTag))
> + return false;
> +
> + return true;</span >
Cleaner way to write this:
return shadowHost && shadowHost->hasTagName(videoTag);
But also, this needs a comment explaining why this is the correct implementation for this function. What is special about video tags?
<span class="quote">> Source/WebCore/accessibility/AccessibilityRenderObject.cpp:2277
> + Node* node = hitTestResult.innerNode();</span >
Should put this into a local variable before the early return just above.
Node* node = hitTestResult.innerNode();
if (!node)
return nullptr;</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>