[Webkit-unassigned] [Bug 155750] [GTK] Add kinetic scrolling

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Mar 31 01:29:24 PDT 2016


--- Comment #3 from Frédéric Wang (:fredw) <fred.wang at free.fr> ---
Comment on attachment 274652
  --> https://bugs.webkit.org/attachment.cgi?id=274652
WIP patch

View in context: https://bugs.webkit.org/attachment.cgi?id=274652&action=review

> Source/WebCore/platform/ScrollAnimationKinetic.h:73
> +

For this three functions you have space before the (), but not for others. I don't remember what is WebKit convention, but maybe you should try running check-webkit-style.

> Source/WebCore/platform/gtk/ScrollAnimatorGtk.cpp:131
> +

extra new line?

> Source/WebCore/platform/gtk/ScrollAnimatorGtk.cpp:138
> +

extra new line?

> Source/WebCore/platform/gtk/ScrollAnimatorGtk.h:77
> +

Do you really want two new lines?

> Source/WebKit2/UIProcess/WebPageProxy.cpp:1811
> +//            return;

Do you mean to remove that code rather than just commenting it out?

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160331/c8e38316/attachment.html>

More information about the webkit-unassigned mailing list