<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] Add kinetic scrolling"
href="https://bugs.webkit.org/show_bug.cgi?id=155750#c3">Comment # 3</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] Add kinetic scrolling"
href="https://bugs.webkit.org/show_bug.cgi?id=155750">bug 155750</a>
from <span class="vcard"><a class="email" href="mailto:fred.wang@free.fr" title="Frédéric Wang (:fredw) <fred.wang@free.fr>"> <span class="fn">Frédéric Wang (:fredw)</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=274652&action=diff" name="attach_274652" title="WIP patch">attachment 274652</a> <a href="attachment.cgi?id=274652&action=edit" title="WIP patch">[details]</a></span>
WIP patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=274652&action=review">https://bugs.webkit.org/attachment.cgi?id=274652&action=review</a>
<span class="quote">> Source/WebCore/platform/ScrollAnimationKinetic.h:73
> +</span >
For this three functions you have space before the (), but not for others. I don't remember what is WebKit convention, but maybe you should try running check-webkit-style.
<span class="quote">> Source/WebCore/platform/gtk/ScrollAnimatorGtk.cpp:131
> +</span >
extra new line?
<span class="quote">> Source/WebCore/platform/gtk/ScrollAnimatorGtk.cpp:138
> +</span >
extra new line?
<span class="quote">> Source/WebCore/platform/gtk/ScrollAnimatorGtk.h:77
> +</span >
Do you really want two new lines?
<span class="quote">> Source/WebKit2/UIProcess/WebPageProxy.cpp:1811
> +// return;</span >
Do you mean to remove that code rather than just commenting it out?</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>