[Webkit-unassigned] [Bug 155795] [JSC] implement String.prototype.padStart() and String.prototype.padEnd() proposal

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=155795

--- Comment #24 from Caitlin Potter (:caitp) <caitp at igalia.com> ---
Comment on attachment 274910
  --> https://bugs.webkit.org/attachment.cgi?id=274910
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=274910&action=review

(In reply to comment #22)
> It appears that the tests added with this change are failing:
> 
> es6.yaml/es6/String.prototype_methods_String.prototype.padEnd.js.default
> es6.yaml/es6/String.prototype_methods_String.prototype.padStart.js.defaul
> 
> es6.yaml/es6/String.prototype_methods_String.prototype.padEnd.js.default:
> ERROR: Unexpected exit code: 136
> es6.yaml/es6/String.prototype_methods_String.prototype.padStart.js.default:
> ERROR: Unexpected exit code: 136
> 
> <https://build.webkit.org/builders/
> Apple%20El%20Capitan%20Release%20JSC%20%28Tests%29/builds/4538>
> <https://build.webkit.org/builders/Apple%20Yosemite%2032-
> bit%20JSC%20%28BuildAndTest%29/builds/8562>

Looking...

>> Source/JavaScriptCore/ChangeLog:21
>> +        * tests/es6/String.prototype_methods_String.prototype.padStart.js: Added.
> 
> These tests do not belong in this directory since these functions are stage 3 for ECMAScript 7.

Fair enough, but there isn't really a more appropriate place to put them yet --- there's a TODO near similar "for future ES spec revisions" entries in es6.yaml, I can add a TODO?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160325/13b8e94e/attachment.html>