<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - [JSC] implement String.prototype.padStart() and String.prototype.padEnd() proposal"
href="https://bugs.webkit.org/show_bug.cgi?id=155795#c24">Comment # 24</a>
on <a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - [JSC] implement String.prototype.padStart() and String.prototype.padEnd() proposal"
href="https://bugs.webkit.org/show_bug.cgi?id=155795">bug 155795</a>
from <span class="vcard"><a class="email" href="mailto:caitp@igalia.com" title="Caitlin Potter (:caitp) <caitp@igalia.com>"> <span class="fn">Caitlin Potter (:caitp)</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=274910&action=diff" name="attach_274910" title="Patch">attachment 274910</a> <a href="attachment.cgi?id=274910&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=274910&action=review">https://bugs.webkit.org/attachment.cgi?id=274910&action=review</a>
(In reply to <a href="show_bug.cgi?id=155795#c22">comment #22</a>)
<span class="quote">> It appears that the tests added with this change are failing:
>
> es6.yaml/es6/String.prototype_methods_String.prototype.padEnd.js.default
> es6.yaml/es6/String.prototype_methods_String.prototype.padStart.js.defaul
>
> es6.yaml/es6/String.prototype_methods_String.prototype.padEnd.js.default:
> ERROR: Unexpected exit code: 136
> es6.yaml/es6/String.prototype_methods_String.prototype.padStart.js.default:
> ERROR: Unexpected exit code: 136
>
> <<a href="https://build.webkit.org/builders/">https://build.webkit.org/builders/</a>
> Apple%20El%20Capitan%20Release%20JSC%20%28Tests%29/builds/4538>
> <<a href="https://build.webkit.org/builders/Apple%20Yosemite%2032">https://build.webkit.org/builders/Apple%20Yosemite%2032</a>-
> bit%20JSC%20%28BuildAndTest%29/builds/8562></span >
Looking...
<span class="quote">>> Source/JavaScriptCore/ChangeLog:21
>> + * tests/es6/String.prototype_methods_String.prototype.padStart.js: Added.
>
> These tests do not belong in this directory since these functions are stage 3 for ECMAScript 7.</span >
Fair enough, but there isn't really a more appropriate place to put them yet --- there's a TODO near similar "for future ES spec revisions" entries in es6.yaml, I can add a TODO?</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>