[Webkit-unassigned] [Bug 155880] Removed redundant #if conditions in ANGLEWebKitBridge.h

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Mar 25 08:39:34 PDT 2016


Alex Christensen <achristensen at apple.com> changed:

           What    |Removed                     |Added
 Attachment #274899|review?, commit-queue?      |review-, commit-queue-
              Flags|                            |

--- Comment #4 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 274899
  --> https://bugs.webkit.org/attachment.cgi?id=274899

View in context: https://bugs.webkit.org/attachment.cgi?id=274899&action=review

>> Source/WebCore/platform/graphics/ANGLEWebKitBridge.h:49
>>  #include "GLSLANG/ShaderLang.h"
> These conditions are very confusing.
> PLATFORM(WIN) && !defined(BUILDING_WITH_CMAKE) is an always false 
> condition, Apple Windows port and WinCairo port always use cmake.
> Shouldn't we include ANGLE/ShaderLang.h unconditionally?

This was needed before the switch to CMake on Windows.  It's not needed any more.  Let's clean it up.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160325/1a38882a/attachment.html>

More information about the webkit-unassigned mailing list