<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:achristensen@apple.com" title="Alex Christensen <achristensen@apple.com>"> <span class="fn">Alex Christensen</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - Removed redundant #if conditions in ANGLEWebKitBridge.h"
href="https://bugs.webkit.org/show_bug.cgi?id=155880">bug 155880</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #274899 Flags</td>
<td>review?, commit-queue?
</td>
<td>review-, commit-queue-
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Removed redundant #if conditions in ANGLEWebKitBridge.h"
href="https://bugs.webkit.org/show_bug.cgi?id=155880#c4">Comment # 4</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Removed redundant #if conditions in ANGLEWebKitBridge.h"
href="https://bugs.webkit.org/show_bug.cgi?id=155880">bug 155880</a>
from <span class="vcard"><a class="email" href="mailto:achristensen@apple.com" title="Alex Christensen <achristensen@apple.com>"> <span class="fn">Alex Christensen</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=274899&action=diff" name="attach_274899" title="Patch">attachment 274899</a> <a href="attachment.cgi?id=274899&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=274899&action=review">https://bugs.webkit.org/attachment.cgi?id=274899&action=review</a>
<span class="quote">>> Source/WebCore/platform/graphics/ANGLEWebKitBridge.h:49
>> #include "GLSLANG/ShaderLang.h"
>
> These conditions are very confusing.
> PLATFORM(WIN) && !defined(BUILDING_WITH_CMAKE) is an always false
> condition, Apple Windows port and WinCairo port always use cmake.
>
> Shouldn't we include ANGLE/ShaderLang.h unconditionally?</span >
This was needed before the switch to CMake on Windows. It's not needed any more. Let's clean it up.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>