[Webkit-unassigned] [Bug 155880] Removed redundant #if conditions in ANGLEWebKitBridge.h

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=155880

--- Comment #2 from Csaba Osztrogonác <ossy at webkit.org> ---
Comment on attachment 274899
  --> https://bugs.webkit.org/attachment.cgi?id=274899
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=274899&action=review

> Source/WebCore/platform/graphics/ANGLEWebKitBridge.h:49
> -#if !PLATFORM(GTK) && !PLATFORM(EFL) && !PLATFORM(WIN) && !defined(BUILDING_WITH_CMAKE)
> +#if !PLATFORM(WIN) && !defined(BUILDING_WITH_CMAKE)
>  #include "ANGLE/ShaderLang.h"
>  #elif PLATFORM(WIN) && !defined(BUILDING_WITH_CMAKE)
>  #include "GLSLANG/ShaderLang.h"

These conditions are very confusing.
PLATFORM(WIN) && !defined(BUILDING_WITH_CMAKE) is an always false 
condition, Apple Windows port and WinCairo port always use cmake.

Shouldn't we include ANGLE/ShaderLang.h unconditionally?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160325/099b49f0/attachment.html>