<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Removed redundant #if conditions in ANGLEWebKitBridge.h"
href="https://bugs.webkit.org/show_bug.cgi?id=155880#c2">Comment # 2</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Removed redundant #if conditions in ANGLEWebKitBridge.h"
href="https://bugs.webkit.org/show_bug.cgi?id=155880">bug 155880</a>
from <span class="vcard"><a class="email" href="mailto:ossy@webkit.org" title="Csaba Osztrogonác <ossy@webkit.org>"> <span class="fn">Csaba Osztrogonác</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=274899&action=diff" name="attach_274899" title="Patch">attachment 274899</a> <a href="attachment.cgi?id=274899&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=274899&action=review">https://bugs.webkit.org/attachment.cgi?id=274899&action=review</a>
<span class="quote">> Source/WebCore/platform/graphics/ANGLEWebKitBridge.h:49
> -#if !PLATFORM(GTK) && !PLATFORM(EFL) && !PLATFORM(WIN) && !defined(BUILDING_WITH_CMAKE)
> +#if !PLATFORM(WIN) && !defined(BUILDING_WITH_CMAKE)
> #include "ANGLE/ShaderLang.h"
> #elif PLATFORM(WIN) && !defined(BUILDING_WITH_CMAKE)
> #include "GLSLANG/ShaderLang.h"</span >
These conditions are very confusing.
PLATFORM(WIN) && !defined(BUILDING_WITH_CMAKE) is an always false
condition, Apple Windows port and WinCairo port always use cmake.
Shouldn't we include ANGLE/ShaderLang.h unconditionally?</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>