[Webkit-unassigned] [Bug 151235] Web Inspector: Type popover should shrink to its content size

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Mar 18 10:24:36 PDT 2016


https://bugs.webkit.org/show_bug.cgi?id=151235

--- Comment #8 from Brian Burg <bburg at apple.com> ---
Comment on attachment 273896
  --> https://bugs.webkit.org/attachment.cgi?id=273896
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=273896&action=review

Thanks for submitting a patch. Please include screenshots of the various cases Joe mentioned with this patch applied so we can move forward.

>>>>> Source/WebInspectorUI/ChangeLog:8
>>>>> +        Popovers in the source code editor that were cuased by hovering over a symbol were unnecessarily large due to min-width and min-height rules. Removed those style rules.
>>>> 
>>>> I think this was added to have better basic support for Object/Class popovers which dynamically fill in content. What happens when you hover an Object/Element/Node type bubble that has a list of properties?
>>> 
>>> If this is the case, perhaps a better solution would be to set some default min size for "Object" popovers and resize the popover to better fit when content changes dynamically.
>> 
>> AFAICT from testing, popovers dynamically resize for Objects, but not for Nodes. I think having a class for Nodes that retains the min-width and min-height rules could be a viable solution.
> 
> The popover for a Node does show all of the data, but it feels cramped.

Typo: 'caused'

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160318/ca447038/attachment.html>


More information about the webkit-unassigned mailing list