<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Web Inspector: Type popover should shrink to its content size"
href="https://bugs.webkit.org/show_bug.cgi?id=151235#c8">Comment # 8</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Web Inspector: Type popover should shrink to its content size"
href="https://bugs.webkit.org/show_bug.cgi?id=151235">bug 151235</a>
from <span class="vcard"><a class="email" href="mailto:bburg@apple.com" title="Brian Burg <bburg@apple.com>"> <span class="fn">Brian Burg</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=273896&action=diff" name="attach_273896" title="Patch">attachment 273896</a> <a href="attachment.cgi?id=273896&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=273896&action=review">https://bugs.webkit.org/attachment.cgi?id=273896&action=review</a>
Thanks for submitting a patch. Please include screenshots of the various cases Joe mentioned with this patch applied so we can move forward.
<span class="quote">>>>>> Source/WebInspectorUI/ChangeLog:8
>>>>> + Popovers in the source code editor that were cuased by hovering over a symbol were unnecessarily large due to min-width and min-height rules. Removed those style rules.
>>>>
>>>> I think this was added to have better basic support for Object/Class popovers which dynamically fill in content. What happens when you hover an Object/Element/Node type bubble that has a list of properties?
>>>
>>> If this is the case, perhaps a better solution would be to set some default min size for "Object" popovers and resize the popover to better fit when content changes dynamically.
>>
>> AFAICT from testing, popovers dynamically resize for Objects, but not for Nodes. I think having a class for Nodes that retains the min-width and min-height rules could be a viable solution.
>
> The popover for a Node does show all of the data, but it feels cramped.</span >
Typo: 'caused'</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>