[Webkit-unassigned] [Bug 155554] AX: attributes to retrieve focusable and editable ancestors

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=155554

--- Comment #15 from Doug Russell <d_russell at apple.com> ---
(In reply to comment #14)
> Comment on attachment 274244 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=274244&action=review
> 
> some review comments inside
> 
> > Source/WebCore/accessibility/AccessibilityNodeObject.cpp:253
> > +    if (canSetFocusAttribute())
> 
> if you start your loop with "this" you can avoid this extra bit of code with
> no extra cost

Will do

> 
> > Source/WebCore/accessibility/AccessibilityNodeObject.cpp:268
> > +    if (isTextControl())
> 
> ditto

Will do

> 
> > Source/WebCore/accessibility/AccessibilityObject.h:1043
> >      
> 
> these seem like they can all go in AccessibilityObject.cpp and then they
> don't have to be virtual

I'll see if I can do that.

> 
> > Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm:3335
> > +    if (!m_object->isWebArea()) {
> 
> if its called on WebArea, it will just end up returning nil right? that
> seems ok doesn't it

Correct. I can remove that check.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160317/f2179132/attachment.html>