<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - AX: attributes to retrieve focusable and editable ancestors"
href="https://bugs.webkit.org/show_bug.cgi?id=155554#c15">Comment # 15</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - AX: attributes to retrieve focusable and editable ancestors"
href="https://bugs.webkit.org/show_bug.cgi?id=155554">bug 155554</a>
from <span class="vcard"><a class="email" href="mailto:d_russell@apple.com" title="Doug Russell <d_russell@apple.com>"> <span class="fn">Doug Russell</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=155554#c14">comment #14</a>)
<span class="quote">> Comment on <span class=""><a href="attachment.cgi?id=274244&action=diff" name="attach_274244" title="Patch">attachment 274244</a> <a href="attachment.cgi?id=274244&action=edit" title="Patch">[details]</a></span>
> Patch
>
> View in context:
> <a href="https://bugs.webkit.org/attachment.cgi?id=274244&action=review">https://bugs.webkit.org/attachment.cgi?id=274244&action=review</a>
>
> some review comments inside
>
> > Source/WebCore/accessibility/AccessibilityNodeObject.cpp:253
> > + if (canSetFocusAttribute())
>
> if you start your loop with "this" you can avoid this extra bit of code with
> no extra cost</span >
Will do
<span class="quote">>
> > Source/WebCore/accessibility/AccessibilityNodeObject.cpp:268
> > + if (isTextControl())
>
> ditto</span >
Will do
<span class="quote">>
> > Source/WebCore/accessibility/AccessibilityObject.h:1043
> >
>
> these seem like they can all go in AccessibilityObject.cpp and then they
> don't have to be virtual</span >
I'll see if I can do that.
<span class="quote">>
> > Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm:3335
> > + if (!m_object->isWebArea()) {
>
> if its called on WebArea, it will just end up returning nil right? that
> seems ok doesn't it</span >
Correct. I can remove that check.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>