[Webkit-unassigned] [Bug 154667] Update twisted version in webkitpy.thirdparty.autoinstalled module.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=154667

Simon Fraser (smfr) <simon.fraser at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #274052|                            |review-
              Flags|                            |

--- Comment #12 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 274052
  --> https://bugs.webkit.org/attachment.cgi?id=274052
Patch for landing

View in context: https://bugs.webkit.org/attachment.cgi?id=274052&action=review

> Tools/ChangeLog:8
> +        Add lasted twisted to webkitpy.thirdparty.autoinstalled.

lasted? latest?

> Tools/Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/twisted_http_server.py:12
> +    from webkitpy.thirdparty.autoinstalled.new_twisted import twisted

Using "new" in code is a mistake. In a year or two, it's no longer new and the read doesn't really know what changed. If it has a version number, say that explicitly.

> Tools/Scripts/webkitpy/thirdparty/__init__.py:160
> +    def _install_new_twisted(self):

Don't say "new".

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160315/84f7df84/attachment.html>