<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:simon.fraser@apple.com" title="Simon Fraser (smfr) <simon.fraser@apple.com>"> <span class="fn">Simon Fraser (smfr)</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - Update twisted version in webkitpy.thirdparty.autoinstalled module."
href="https://bugs.webkit.org/show_bug.cgi?id=154667">bug 154667</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #274052 Flags</td>
<td>
</td>
<td>review-
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Update twisted version in webkitpy.thirdparty.autoinstalled module."
href="https://bugs.webkit.org/show_bug.cgi?id=154667#c12">Comment # 12</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Update twisted version in webkitpy.thirdparty.autoinstalled module."
href="https://bugs.webkit.org/show_bug.cgi?id=154667">bug 154667</a>
from <span class="vcard"><a class="email" href="mailto:simon.fraser@apple.com" title="Simon Fraser (smfr) <simon.fraser@apple.com>"> <span class="fn">Simon Fraser (smfr)</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=274052&action=diff" name="attach_274052" title="Patch for landing">attachment 274052</a> <a href="attachment.cgi?id=274052&action=edit" title="Patch for landing">[details]</a></span>
Patch for landing
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=274052&action=review">https://bugs.webkit.org/attachment.cgi?id=274052&action=review</a>
<span class="quote">> Tools/ChangeLog:8
> + Add lasted twisted to webkitpy.thirdparty.autoinstalled.</span >
lasted? latest?
<span class="quote">> Tools/Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/twisted_http_server.py:12
> + from webkitpy.thirdparty.autoinstalled.new_twisted import twisted</span >
Using "new" in code is a mistake. In a year or two, it's no longer new and the read doesn't really know what changed. If it has a version number, say that explicitly.
<span class="quote">> Tools/Scripts/webkitpy/thirdparty/__init__.py:160
> + def _install_new_twisted(self):</span >
Don't say "new".</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>