[Webkit-unassigned] [Bug 155255] MemoryPressureHandler doesn't work if cgroups aren't present in Linux

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=155255

Martin Robinson <mrobinson at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #273748|review?                     |review+
              Flags|                            |

--- Comment #6 from Martin Robinson <mrobinson at webkit.org> ---
Comment on attachment 273748
  --> https://bugs.webkit.org/attachment.cgi?id=273748
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=273748&action=review

Looks good to me, but I think it makes sense to have someone more closely involved with the port sign off an polling proc every second.

> Source/WebCore/platform/linux/MemoryPressureHandlerLinux.cpp:56
> +static const size_t s_memoryCriticalLimit = 100 * KB * KB; // 100 MB
> +static const size_t s_memoryNonCriticalLimit = 300 * KB * KB; // 300 MB

It might be worth discussing a bit where these numbers come from. A comment here or a note in the ChangeLog or bug is fine.

> Source/WebCore/platform/linux/MemoryPressureHandlerLinux.cpp:224
> +    if (!installUsingCgroups() && !installUsingMeminfo())
> +        return;

Much nicer!

> Source/WebCore/platform/linux/MemoryPressureHandlerLinux.cpp:227
>      if (ReliefLogger::loggingEnabled() && isUnderMemoryPressure())
>          LOG(MemoryPressure, "System is no longer under memory pressure.");

This is quite strange. If isUnderMemoryPressure returns true, a message is printed that the system is not under memory pressure. Do you have understand why this is?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160311/0c310ede/attachment.html>