<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:mrobinson@webkit.org" title="Martin Robinson <mrobinson@webkit.org>"> <span class="fn">Martin Robinson</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - MemoryPressureHandler doesn't work if cgroups aren't present in Linux"
href="https://bugs.webkit.org/show_bug.cgi?id=155255">bug 155255</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #273748 Flags</td>
<td>review?
</td>
<td>review+
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - MemoryPressureHandler doesn't work if cgroups aren't present in Linux"
href="https://bugs.webkit.org/show_bug.cgi?id=155255#c6">Comment # 6</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - MemoryPressureHandler doesn't work if cgroups aren't present in Linux"
href="https://bugs.webkit.org/show_bug.cgi?id=155255">bug 155255</a>
from <span class="vcard"><a class="email" href="mailto:mrobinson@webkit.org" title="Martin Robinson <mrobinson@webkit.org>"> <span class="fn">Martin Robinson</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=273748&action=diff" name="attach_273748" title="Patch">attachment 273748</a> <a href="attachment.cgi?id=273748&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=273748&action=review">https://bugs.webkit.org/attachment.cgi?id=273748&action=review</a>
Looks good to me, but I think it makes sense to have someone more closely involved with the port sign off an polling proc every second.
<span class="quote">> Source/WebCore/platform/linux/MemoryPressureHandlerLinux.cpp:56
> +static const size_t s_memoryCriticalLimit = 100 * KB * KB; // 100 MB
> +static const size_t s_memoryNonCriticalLimit = 300 * KB * KB; // 300 MB</span >
It might be worth discussing a bit where these numbers come from. A comment here or a note in the ChangeLog or bug is fine.
<span class="quote">> Source/WebCore/platform/linux/MemoryPressureHandlerLinux.cpp:224
> + if (!installUsingCgroups() && !installUsingMeminfo())
> + return;</span >
Much nicer!
<span class="quote">> Source/WebCore/platform/linux/MemoryPressureHandlerLinux.cpp:227
> if (ReliefLogger::loggingEnabled() && isUnderMemoryPressure())
> LOG(MemoryPressure, "System is no longer under memory pressure.");</span >
This is quite strange. If isUnderMemoryPressure returns true, a message is printed that the system is not under memory pressure. Do you have understand why this is?</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>