[Webkit-unassigned] [Bug 155056] AX: Force allow user zoom

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=155056

Simon Fraser (smfr) <simon.fraser at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #273657|                            |review+
              Flags|                            |

--- Comment #54 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 273657
  --> https://bugs.webkit.org/attachment.cgi?id=273657
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=273657&action=review

> Source/WebCore/Configurations/WebCoreTestSupport.xcconfig:53
> +OTHER_LDFLAGS[sdk=iphoneos*] = $(ASAN_OTHER_LDFLAGS) -lAccessibility;
> +OTHER_LDFLAGS[sdk=iphonesimulator*] = $(ASAN_OTHER_LDFLAGS) -lAccessibility;

Is it OK to link with Accessibility all the way back to Monarch? We have open source builders on Monarch.

> Source/WebCore/page/ViewportConfiguration.cpp:194
> +    if (m_forceAlwaysUserScalable)
> +        minimumScale = std::min(minimumScale, forceAlwaysUserScalableMinimumScale);

This worries me a bit because there are pages which load by default with scale > 1 (e.g. "width=200px" in the viewport meta tag), and you're going to cause them to shrink down.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160311/e72c9ae6/attachment.html>