<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:simon.fraser@apple.com" title="Simon Fraser (smfr) <simon.fraser@apple.com>"> <span class="fn">Simon Fraser (smfr)</span></a>
</span> changed
<a class="bz_bug_link
bz_status_REOPENED "
title="REOPENED - AX: Force allow user zoom"
href="https://bugs.webkit.org/show_bug.cgi?id=155056">bug 155056</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #273657 Flags</td>
<td>
</td>
<td>review+
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_REOPENED "
title="REOPENED - AX: Force allow user zoom"
href="https://bugs.webkit.org/show_bug.cgi?id=155056#c54">Comment # 54</a>
on <a class="bz_bug_link
bz_status_REOPENED "
title="REOPENED - AX: Force allow user zoom"
href="https://bugs.webkit.org/show_bug.cgi?id=155056">bug 155056</a>
from <span class="vcard"><a class="email" href="mailto:simon.fraser@apple.com" title="Simon Fraser (smfr) <simon.fraser@apple.com>"> <span class="fn">Simon Fraser (smfr)</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=273657&action=diff" name="attach_273657" title="patch">attachment 273657</a> <a href="attachment.cgi?id=273657&action=edit" title="patch">[details]</a></span>
patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=273657&action=review">https://bugs.webkit.org/attachment.cgi?id=273657&action=review</a>
<span class="quote">> Source/WebCore/Configurations/WebCoreTestSupport.xcconfig:53
> +OTHER_LDFLAGS[sdk=iphoneos*] = $(ASAN_OTHER_LDFLAGS) -lAccessibility;
> +OTHER_LDFLAGS[sdk=iphonesimulator*] = $(ASAN_OTHER_LDFLAGS) -lAccessibility;</span >
Is it OK to link with Accessibility all the way back to Monarch? We have open source builders on Monarch.
<span class="quote">> Source/WebCore/page/ViewportConfiguration.cpp:194
> + if (m_forceAlwaysUserScalable)
> + minimumScale = std::min(minimumScale, forceAlwaysUserScalableMinimumScale);</span >
This worries me a bit because there are pages which load by default with scale > 1 (e.g. "width=200px" in the viewport meta tag), and you're going to cause them to shrink down.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>