[Webkit-unassigned] [Bug 139946] Fix typo in StyleResolveTree.cpp

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=139946

Brent Fulgham <bfulgham at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bfulgham at webkit.org

--- Comment #6 from Brent Fulgham <bfulgham at webkit.org> ---
(In reply to comment #5)
> (In reply to comment #4)
> > Comment on attachment 243746 [details]
> > Patch
> > 
> > View in context:
> > https://bugs.webkit.org/attachment.cgi?id=243746&action=review
> > 
> > > Source/WebCore/ChangeLog:8
> > > +        No new tests. Behaviour wasn't changed.
> > 
> > If there is no change in behavior, what is the rationale for making this
> > code change?
> 
> Final behavior wasn't changed. But code before change had meaningless check
> for:
> WKContentChange() != WKContentVisibilityChange

Yes, this code is wrong. WKContentChange() is not a function, it's a type -- so this is like saying "int() != WKContentVisibilityChange"

The correct method is WKObservedContentChange().

I'm not sure what impact this has in practice, but it should be corrected.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160310/9bdd5a7e/attachment.html>