<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:bfulgham@webkit.org" title="Brent Fulgham <bfulgham@webkit.org>"> <span class="fn">Brent Fulgham</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - Fix typo in StyleResolveTree.cpp"
href="https://bugs.webkit.org/show_bug.cgi?id=139946">bug 139946</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">CC</td>
<td>
</td>
<td>bfulgham@webkit.org
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Fix typo in StyleResolveTree.cpp"
href="https://bugs.webkit.org/show_bug.cgi?id=139946#c6">Comment # 6</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Fix typo in StyleResolveTree.cpp"
href="https://bugs.webkit.org/show_bug.cgi?id=139946">bug 139946</a>
from <span class="vcard"><a class="email" href="mailto:bfulgham@webkit.org" title="Brent Fulgham <bfulgham@webkit.org>"> <span class="fn">Brent Fulgham</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=139946#c5">comment #5</a>)
<span class="quote">> (In reply to <a href="show_bug.cgi?id=139946#c4">comment #4</a>)
> > Comment on <span class=""><a href="attachment.cgi?id=243746&action=diff" name="attach_243746" title="Patch">attachment 243746</a> <a href="attachment.cgi?id=243746&action=edit" title="Patch">[details]</a></span>
> > Patch
> >
> > View in context:
> > <a href="https://bugs.webkit.org/attachment.cgi?id=243746&action=review">https://bugs.webkit.org/attachment.cgi?id=243746&action=review</a>
> >
> > > Source/WebCore/ChangeLog:8
> > > + No new tests. Behaviour wasn't changed.
> >
> > If there is no change in behavior, what is the rationale for making this
> > code change?
>
> Final behavior wasn't changed. But code before change had meaningless check
> for:
> WKContentChange() != WKContentVisibilityChange</span >
Yes, this code is wrong. WKContentChange() is not a function, it's a type -- so this is like saying "int() != WKContentVisibilityChange"
The correct method is WKObservedContentChange().
I'm not sure what impact this has in practice, but it should be corrected.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>