[Webkit-unassigned] [Bug 155292] [GTK] Scrollbars are broken once again with current GTK+ master

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=155292

Michael Catanzaro <mcatanzaro at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #273553|review?                     |review+
              Flags|                            |

--- Comment #2 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 273553
  --> https://bugs.webkit.org/attachment.cgi?id=273553
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=273553&action=review

I'm surprised that some of these changes are not guarded by GTK_CHECK_VERSION, but I presume you've tested it with 3.16 or 3.18.

> Source/WebCore/ChangeLog:8
> +        Most of the trouch theming properties have been moved to the

trough

> Source/WebCore/platform/gtk/ScrollbarThemeGtk.cpp:217
> +    gtk_widget_path_iter_add_class(path.get(), -1, orientation == VerticalScrollbar ? "right" : "bottom");

Are you sure this is right? I thought these were used to indicate the position of the scrollbar within its trough, not the position of the scrollbar in the window itself. So a vertical scrollbar should start with the "top" style class rather than "right", and the horizontal scrollbar would start with "left" rather than "bottom". Then once the scrollbar moves any distance on the trough, that style class should be removed, and restored only if it reaches the very top/left/right/bottom again. A pain, so I thought it OK to ignore.

However I didn't check the code, and if you tell me these are now "overloaded" and necessary to get the border correct, then that's fine....

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160310/4284d632/attachment.html>