<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:mcatanzaro@igalia.com" title="Michael Catanzaro <mcatanzaro@igalia.com>"> <span class="fn">Michael Catanzaro</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] Scrollbars are broken once again with current GTK+ master"
href="https://bugs.webkit.org/show_bug.cgi?id=155292">bug 155292</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #273553 Flags</td>
<td>review?
</td>
<td>review+
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] Scrollbars are broken once again with current GTK+ master"
href="https://bugs.webkit.org/show_bug.cgi?id=155292#c2">Comment # 2</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] Scrollbars are broken once again with current GTK+ master"
href="https://bugs.webkit.org/show_bug.cgi?id=155292">bug 155292</a>
from <span class="vcard"><a class="email" href="mailto:mcatanzaro@igalia.com" title="Michael Catanzaro <mcatanzaro@igalia.com>"> <span class="fn">Michael Catanzaro</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=273553&action=diff" name="attach_273553" title="Patch">attachment 273553</a> <a href="attachment.cgi?id=273553&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=273553&action=review">https://bugs.webkit.org/attachment.cgi?id=273553&action=review</a>
I'm surprised that some of these changes are not guarded by GTK_CHECK_VERSION, but I presume you've tested it with 3.16 or 3.18.
<span class="quote">> Source/WebCore/ChangeLog:8
> + Most of the trouch theming properties have been moved to the</span >
trough
<span class="quote">> Source/WebCore/platform/gtk/ScrollbarThemeGtk.cpp:217
> + gtk_widget_path_iter_add_class(path.get(), -1, orientation == VerticalScrollbar ? "right" : "bottom");</span >
Are you sure this is right? I thought these were used to indicate the position of the scrollbar within its trough, not the position of the scrollbar in the window itself. So a vertical scrollbar should start with the "top" style class rather than "right", and the horizontal scrollbar would start with "left" rather than "bottom". Then once the scrollbar moves any distance on the trough, that style class should be removed, and restored only if it reaches the very top/left/right/bottom again. A pain, so I thought it OK to ignore.
However I didn't check the code, and if you tell me these are now "overloaded" and necessary to get the border correct, then that's fine....</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>