[Webkit-unassigned] [Bug 137139] Failed to run SunSpider 1.0.2 in Chrome

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=137139

--- Comment #11 from Filip Pizlo <fpizlo at apple.com> ---
Comment on attachment 238795
  --> https://bugs.webkit.org/attachment.cgi?id=238795
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=238795&action=review

I'll let the r- stand because I don't agree with the diagnosis or fix.

> PerformanceTests/SunSpider/ChangeLog:11
> +        Chrome uses standalone process to handle iframe. Thus there is a
> +        chance before recordResult is executed, a new round of test is
> +        triggered and the content of iframe is replaced. The result of
> +        previous case would never be recorded and result in errors in
> +        results.html.

I don't buy this.  To my understanding, Chrome doesn't do it this way.

> PerformanceTests/SunSpider/ChangeLog:12
> +        The commit also removes some unexpected trailing whitespaces.

We usually don't mix style changes with functional changes like this, especially when it's just whitespace.

> PerformanceTests/SunSpider/resources/driver-TEMPLATE.html:29
> - OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 
> + OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.

Please revert.

> PerformanceTests/SunSpider/resources/driver-TEMPLATE.html:57
> -    for (var start = new Date; new Date - start < warmupMS; ) {
> +    for (var start = new Date; new Date - start < warmupMS;) {

Revert.

> PerformanceTests/SunSpider/resources/driver-TEMPLATE.html:65
> -function start() 
> +function start()

Revert.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160309/7d990cba/attachment.html>