<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED INVALID - Failed to run SunSpider 1.0.2 in Chrome"
href="https://bugs.webkit.org/show_bug.cgi?id=137139#c11">Comment # 11</a>
on <a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED INVALID - Failed to run SunSpider 1.0.2 in Chrome"
href="https://bugs.webkit.org/show_bug.cgi?id=137139">bug 137139</a>
from <span class="vcard"><a class="email" href="mailto:fpizlo@apple.com" title="Filip Pizlo <fpizlo@apple.com>"> <span class="fn">Filip Pizlo</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=238795&action=diff" name="attach_238795" title="Patch">attachment 238795</a> <a href="attachment.cgi?id=238795&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=238795&action=review">https://bugs.webkit.org/attachment.cgi?id=238795&action=review</a>
I'll let the r- stand because I don't agree with the diagnosis or fix.
<span class="quote">> PerformanceTests/SunSpider/ChangeLog:11
> + Chrome uses standalone process to handle iframe. Thus there is a
> + chance before recordResult is executed, a new round of test is
> + triggered and the content of iframe is replaced. The result of
> + previous case would never be recorded and result in errors in
> + results.html.</span >
I don't buy this. To my understanding, Chrome doesn't do it this way.
<span class="quote">> PerformanceTests/SunSpider/ChangeLog:12
> + The commit also removes some unexpected trailing whitespaces.</span >
We usually don't mix style changes with functional changes like this, especially when it's just whitespace.
<span class="quote">> PerformanceTests/SunSpider/resources/driver-TEMPLATE.html:29
> - OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
> + OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.</span >
Please revert.
<span class="quote">> PerformanceTests/SunSpider/resources/driver-TEMPLATE.html:57
> - for (var start = new Date; new Date - start < warmupMS; ) {
> + for (var start = new Date; new Date - start < warmupMS;) {</span >
Revert.
<span class="quote">> PerformanceTests/SunSpider/resources/driver-TEMPLATE.html:65
> -function start()
> +function start()</span >
Revert.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>