[Webkit-unassigned] [Bug 159144] Too much duplicated code in LayerTreeHosts implementations

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jun 29 04:41:42 PDT 2016


Zan Dobersek <zan at falconsigh.net> changed:

           What    |Removed                     |Added
 Attachment #282123|review?                     |review+
              Flags|                            |

--- Comment #8 from Zan Dobersek <zan at falconsigh.net> ---
Comment on attachment 282123
  --> https://bugs.webkit.org/attachment.cgi?id=282123
Try to fix EFL build

View in context: https://bugs.webkit.org/attachment.cgi?id=282123&action=review

>>>> Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/ThreadedCoordinatedLayerTreeHost.h:65
>>>> +    class CompositorClient final : public ThreadedCompositor::Client {
>>> What about to add WTF_MAKE_NONCOPYABLE to make sure?
>> It's private and stack allocated only, LayerTreeHost is already non copyable, so I don't see how it can be copied.
> It's not stack-allocated, it's allocated on the heap by being located inside the ThreadedCoordinatedLayerTreeHost.
> It can be copied, ThreadedCompositor::Client is copyable and the LayerTreeHost reference doesn't prevent it either.


You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160629/64afb5b6/attachment-0001.html>

More information about the webkit-unassigned mailing list