<html>
    <head>
      <base href="https://bugs.webkit.org/" />
    </head>
    <body><span class="vcard"><a class="email" href="mailto:zan&#64;falconsigh.net" title="Zan Dobersek &lt;zan&#64;falconsigh.net&gt;"> <span class="fn">Zan Dobersek</span></a>
</span> changed
              <a class="bz_bug_link 
          bz_status_NEW "
   title="NEW - Too much duplicated code in LayerTreeHosts implementations"
   href="https://bugs.webkit.org/show_bug.cgi?id=159144">bug 159144</a>
        <br>
             <table border="1" cellspacing="0" cellpadding="8">
          <tr>
            <th>What</th>
            <th>Removed</th>
            <th>Added</th>
          </tr>

         <tr>
           <td style="text-align:right;">Attachment #282123 Flags</td>
           <td>review?
           </td>
           <td>review+
           </td>
         </tr></table>
      <p>
        <div>
            <b><a class="bz_bug_link 
          bz_status_NEW "
   title="NEW - Too much duplicated code in LayerTreeHosts implementations"
   href="https://bugs.webkit.org/show_bug.cgi?id=159144#c8">Comment # 8</a>
              on <a class="bz_bug_link 
          bz_status_NEW "
   title="NEW - Too much duplicated code in LayerTreeHosts implementations"
   href="https://bugs.webkit.org/show_bug.cgi?id=159144">bug 159144</a>
              from <span class="vcard"><a class="email" href="mailto:zan&#64;falconsigh.net" title="Zan Dobersek &lt;zan&#64;falconsigh.net&gt;"> <span class="fn">Zan Dobersek</span></a>
</span></b>
        <pre>Comment on <span class=""><a href="attachment.cgi?id=282123&amp;action=diff" name="attach_282123" title="Try to fix EFL build">attachment 282123</a> <a href="attachment.cgi?id=282123&amp;action=edit" title="Try to fix EFL build">[details]</a></span>
Try to fix EFL build

View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=282123&amp;action=review">https://bugs.webkit.org/attachment.cgi?id=282123&amp;action=review</a>

<span class="quote">&gt;&gt;&gt;&gt; Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/ThreadedCoordinatedLayerTreeHost.h:65
&gt;&gt;&gt;&gt; +    class CompositorClient final : public ThreadedCompositor::Client {
&gt;&gt;&gt; 
&gt;&gt;&gt; What about to add WTF_MAKE_NONCOPYABLE to make sure?
&gt;&gt; 
&gt;&gt; It's private and stack allocated only, LayerTreeHost is already non copyable, so I don't see how it can be copied.
&gt; 
&gt; It's not stack-allocated, it's allocated on the heap by being located inside the ThreadedCoordinatedLayerTreeHost.
&gt; 
&gt; It can be copied, ThreadedCompositor::Client is copyable and the LayerTreeHost reference doesn't prevent it either.</span >

r=me with WTF_MAKE_NONCOPYABLE.</pre>
        </div>
      </p>
      <hr>
      <span>You are receiving this mail because:</span>
      
      <ul>
          <li>You are the assignee for the bug.</li>
      </ul>
    </body>
</html>