[Webkit-unassigned] [Bug 158083] LLInt should support other types of prototype GetById caching.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=158083

--- Comment #94 from Caio Lima <ticaiolima at gmail.com> ---
(In reply to comment #93)
> Comment on attachment 281613 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=281613&action=review
> 
> Looks good! I just have a couple of comments/questions.
> 
> > Source/JavaScriptCore/ChangeLog:12
> > +        offset of a object to call a getter function and get_by_id_proto_custo
> 
> typo: git_by_id_proto_custom

Nice Catch =)

> > Source/JavaScriptCore/llint/LowLevelInterpreter64.asm:1299
> > +   bineq 0, dest, .loadEncodedThisValueDone
> 
> Does this get assembled to: 
> test: dest, dest 
> jz: .loadEncodedThisValueDone
> ? If not, we should probably try to figure out how to make that happen.

Yes, Here is the code compiled:

0x100dbaf1f <+13003>: movq   0x30(%r13,%r8,8), %rsi
0x100dbaf24 <+13008>: testl  %esi, %esi
0x100dbaf26 <+13010>: jne    0x100dbaf2f               ; <+13019>
0x100dbaf2c <+13016>: movq   %rcx, %rsi
0x100dbaf2f <+13019>: movq   0x28(%r13,%r8,8), %rax

I am going to rebase the code and send the Patch updated

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160629/e5495288/attachment.html>