<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - LLInt should support other types of prototype GetById caching."
href="https://bugs.webkit.org/show_bug.cgi?id=158083#c94">Comment # 94</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - LLInt should support other types of prototype GetById caching."
href="https://bugs.webkit.org/show_bug.cgi?id=158083">bug 158083</a>
from <span class="vcard"><a class="email" href="mailto:ticaiolima@gmail.com" title="Caio Lima <ticaiolima@gmail.com>"> <span class="fn">Caio Lima</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=158083#c93">comment #93</a>)
<span class="quote">> Comment on <span class=""><a href="attachment.cgi?id=281613&action=diff" name="attach_281613" title="Patch">attachment 281613</a> <a href="attachment.cgi?id=281613&action=edit" title="Patch">[details]</a></span>
> Patch
>
> View in context:
> <a href="https://bugs.webkit.org/attachment.cgi?id=281613&action=review">https://bugs.webkit.org/attachment.cgi?id=281613&action=review</a>
>
> Looks good! I just have a couple of comments/questions.
>
> > Source/JavaScriptCore/ChangeLog:12
> > + offset of a object to call a getter function and get_by_id_proto_custo
>
> typo: git_by_id_proto_custom</span >
Nice Catch =)
<span class="quote">> > Source/JavaScriptCore/llint/LowLevelInterpreter64.asm:1299
> > + bineq 0, dest, .loadEncodedThisValueDone
>
> Does this get assembled to:
> test: dest, dest
> jz: .loadEncodedThisValueDone
> ? If not, we should probably try to figure out how to make that happen.</span >
Yes, Here is the code compiled:
0x100dbaf1f <+13003>: movq 0x30(%r13,%r8,8), %rsi
0x100dbaf24 <+13008>: testl %esi, %esi
0x100dbaf26 <+13010>: jne 0x100dbaf2f ; <+13019>
0x100dbaf2c <+13016>: movq %rcx, %rsi
0x100dbaf2f <+13019>: movq 0x28(%r13,%r8,8), %rax
I am going to rebase the code and send the Patch updated</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>